Fix flaky test #2078
Merged
Fix flaky test #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
Current coverage is 91.42%@@ master #2078 diff @@
==========================================
Files 93 93
Lines 6537 6694 +157
Methods 1169 1182 +13
Messages 0 0
Branches 1370 1402 +32
==========================================
+ Hits 6010 6120 +110
- Misses 527 574 +47
Partials 0 0
|
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to have helped with the flaky test, by using
getOneSchemato get the schema, instead ofthis.datawhich can get unloaded randomly.